Re: [tor-bugs] #15344 [Tor]: Integrate tests into automake test suite

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#15344: Integrate tests into automake test suite
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  cypherpunks
  cypherpunks            |     Status:  closed
         Type:           |  Milestone:  Tor: 0.2.7.x-final
  enhancement            |    Version:  Tor: 0.2.7
     Priority:  trivial  |   Keywords:  testing, 027-triaged-1-in, SponsorS
    Component:  Tor      |  Parent ID:
   Resolution:  fixed    |
Actual Points:           |
       Points:  small    |
-------------------------+-------------------------------------------------

Comment (by cypherpunks):

 Sorry for the incomplete patch. I tend to focus on portability but not so
 much on backwards compatibility. Great fix, i couldn't find the problem
 myself. However, i have two remarks on your fixes. Do with it what you
 want, it's nothing major.
 1. commit ecf98313d673f010b52f8d29c352cd9b8f145734 doesn't do anything but
 make unprocessed files executable. AFAIK it didn't contribute in fixing
 the problem and smells like bad practice. Therefore, IMO the commit should
 be reverted.
 2. all of the files generated in the build directory have permissions 600
 (or 700 for executable files). For consistency the wrapper scripts should
 also be 700 (or maybe use `chmod u+x`).

 Just my two (remark) cents.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15344#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs