[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #18765 [Tor]: strlcat

#18765: strlcat
-------------------------+---------------------
 Reporter:  cypherpunks  |          Owner:
     Type:  defect       |         Status:  new
 Priority:  Medium       |      Milestone:
Component:  Tor          |        Version:
 Severity:  Normal       |     Resolution:
 Keywords:               |  Actual Points:
Parent ID:               |         Points:
 Reviewer:               |        Sponsor:
-------------------------+---------------------

Comment (by cypherpunks):

 Replying to [comment:2 nickm]:
 > What is the actual improvement here?
 When looking at the diff of the current version and the version Tor
 includes (see http://cvsweb.openbsd.org/cgi-
 bin/cvsweb/src/lib/libc/string/strlcat.c.diff?r1=1.8&r2=1.16&f=h) we can
 see that the license is updated, the useless `rcsid` variable is removed,
 the register keyword isn't used anymore, variable names are more
 descriptive, more use of `const`, and some comments are improved. AFAICT
 functionality has not changed.

 I assume the TS thought there was a bug in the code, but i don't think it
 has (see comment:1).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18765#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs