[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #18090 [Tor Browser]: Torcrazybutton eats all memory and crashes Tor Browser

#18090: Torcrazybutton eats all memory and crashes Tor Browser
-------------------------------------------------+-------------------------
 Reporter:  bugzilla                             |          Owner:  tbb-
     Type:  defect                               |  team
 Priority:  Medium                               |         Status:  new
Component:  Tor Browser                          |      Milestone:
 Severity:  Major                                |        Version:
 Keywords:  tbb-crash, tbb-performance-leaking,  |     Resolution:
  tbb-oom, tbb-torbutton                         |  Actual Points:
Parent ID:  #18047                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by cypherpunks):

 Replying to [comment:11 bugzilla]:
 > WCF_reportPageError@chrome://torbutton/content/torbutton.js:3066:13/n

 I don't know enough about XPCOM programming (or Javascript, for that
 matter), but this smells like unbounded recursion.

 Looking at the code it seems this could be happening since
 `torbutton_console_observer.observe` does not properly handle re-entrance.
 If more than 1 of those `web-console-create` notifications are delivered,
 a call to that `com.ui.reportPageError` thing will forever recurse.

 See what I mean?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18090#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs