[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #15197 [Tor Browser]: Rebase Tor Browser patches to ESR 45
#15197: Rebase Tor Browser patches to ESR 45
-------------------------------------------------+-------------------------
Reporter: gk | Owner:
Type: task | arthuredelstein
Priority: Very High | Status:
Component: Tor Browser | needs_revision
Severity: Critical | Milestone:
Keywords: ff45-esr, TorBrowserTeam201604, | Version:
tbb-6.0a5 | Resolution:
Parent ID: | Actual Points:
Reviewer: | Points:
| Sponsor:
| SponsorU
-------------------------------------------------+-------------------------
Comment (by mcs):
Replying to [comment:34 gk]:
> Replying to [comment:31 mcs]:
> > Replying to [comment:24 mcs]:
> > > For #12827 (f1a5dfae111d9ab281e766a67ae00559cc13578a), some
additional changes are needed. Kathy and I can provide a fixup patch or a
revised patch; which one do you prefer?
> >
> > We went ahead and created a replacement patch. I will attach it to
this ticket.
>
> Arthur: Getting that one properly reviewed and tested should not prevent
a new branch with all the rebase related fixes we can use for our
nightlies. I can imagine just reverting the old SVG patch when we land the
new one and just cutting the old one and the revert out when rebasing
later to a new ESR45.
We will want the revised patch soon. Without it, debug builds crash due
to a failed assertion in GetProgressTracker() (inside image/Image.h) when
asked to load SVG images, assuming you have set svg.in-content.enabled =
false. I have not tried a non-debug build, but looking at the code I
think a NULL pointer dereference will occur.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15197#comment:44>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs