[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #16792 [Tor]: Have a way to mark lines as "unreachable by unit tests"

#16792: Have a way to mark lines as "unreachable by unit tests"
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  nickm
     Type:  enhancement                          |         Status:
 Priority:  High                                 |  needs_review
Component:  Tor                                  |      Milestone:  Tor:
 Severity:  Normal                               |  0.2.9.x-final
 Keywords:  testing, 028-triaged,                |        Version:
  TorCoreTeam201604                              |     Resolution:
Parent ID:                                       |  Actual Points:  small
 Reviewer:                                       |         Points:  small
                                                 |        Sponsor:
                                                 |  SponsorS-can
-------------------------------------------------+-------------------------

Comment (by nickm):

 Note: my approach to when we should use these LCOV_EXCL lines differs from
 the approach taken in tortls.c and config.c so far. I believe that we
 should only mark a line as excluded when it is truly unreachable.  The
 annotations in tortls.c think that "maybe unreachable" can be a good
 enough reason.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16792#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs