[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #18213 [Tor]: The parameter WarnUnsafeSocks does not work as specified in the documentation, no warning is logged in the log file
#18213: The parameter WarnUnsafeSocks does not work as specified in the
documentation, no warning is logged in the log file
-----------------------------------------------+---------------------------
Reporter: propropus | Owner:
Type: defect | Status:
Priority: High | needs_information
Component: Tor | Milestone: Tor:
Severity: Major | 0.2.8.x-final
Keywords: WarnUnsafeSocks, Log 027-backport | Version:
Parent ID: | Resolution:
Reviewer: | Actual Points:
| Points:
| Sponsor:
-----------------------------------------------+---------------------------
Description changed by arma:
Old description:
> The parameter WarnUnsafeSocks does not work as specified in the
> documentation, no warning is logged in the log file when a connection is
> done to an ip address.
>
> If WarnUnsafeSocks 1 (default) is set there is no warning in the log
> file.
> If you look at the code for log_unsafe_socks_warning, the only case where
> an error is logged is when safe_socks is true. safe_socks is true only
> when SafeSocks parameter is set, but not when WarnUnsafeSocks is set.
>
> The code should be
>
> if (safe_socks || options->WarnUnsafeSocks) {
>
> instead of
>
> if (safe_socks) {
New description:
The parameter WarnUnsafeSocks does not work as specified in the
documentation, no warning is logged in the log file when a connection is
done to an ip address.
If WarnUnsafeSocks 1 (default) is set there is no warning in the log file.
If you look at the code for log_unsafe_socks_warning, the only case where
an error is logged is when safe_socks is true. safe_socks is true only
when SafeSocks parameter is set, but not when WarnUnsafeSocks is set.
The code should be
{{{
if (safe_socks || options->WarnUnsafeSocks) {
}}}
instead of
{{{
if (safe_socks) {
}}}
--
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18213#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs