[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #18466 [Applications/Tor Browser]: Fix torbutton for ESR45
#18466: Fix torbutton for ESR45
-------------------------------------------------+-------------------------
Reporter: arthuredelstein | Owner: gk
Type: defect | Status: closed
Priority: High | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Critical | Resolution: fixed
Keywords: ff45-esr, TorBrowserTeam201604R, | Actual Points:
GeorgKoppen201604 tbb-6.0a5 | Points:
Parent ID: | Sponsor:
Reviewer: |
-------------------------------------------------+-------------------------
Comment (by arthuredelstein):
Replying to [comment:5 mcs]:
> Kathy and I looked at c55c1ef497f7b2a97ff7c9b0af351a065df3b477 and
594b2bbc55a0bbc2f548356f44ea191d4e2466e2. Your changes look good. We have
two questions:
> Can you give us some background on why statements such as {{{let mozilla
= mozilla || {};}}} were needed previously? Or maybe they were not needed?
These were not needed. I used this to avoid accidentally destroying a
`mozilla` object (for example) if it had already been defined. But these
JS modules are isolated from all other code, so there is no risk of that.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18466#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs