[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #18616 [Core Tor/Tor]: Bug: Node search initiated by. Stack trace:



#18616: Bug: Node search initiated by. Stack trace:
-------------------------------------------------+-------------------------
 Reporter:  toralf                               |          Owner:
     Type:  defect                               |         Status:
 Priority:  Medium                               |  needs_revision
Component:  Core Tor/Tor                         |      Milestone:  Tor:
 Severity:  Normal                               |  0.2.8.x-final
 Keywords:  regression, must-fix-before-028-rc,  |        Version:  Tor:
  TorCoreTeam201604                              |  0.2.8.1-alpha
Parent ID:                                       |     Resolution:
 Reviewer:                                       |  Actual Points:
                                                 |         Points:
                                                 |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by teor):

 I think I can update the patch so it cleanly answers the following
 questions:
 * do we have a dirport open?
   * if we have a dirport open, is the DirPort reachable?
     * if the DirPort is reachable, do we want to advertise it?
 * would we answer begindir requests?
   * if we would answer begindir requests, is the ORPort reachable?
     * if the ORPort is reachable, do we want to advertise begindir
 support?

 As nickm notes in comment 11, I need to make sure we do the reachability
 and advertisability checks, store the results, and then use the results to
 answer these questions.

 As dgoulet notes in 13 & 15, I should also remove redundant function
 calls.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18616#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs