[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #18875 [Metrics/metrics-lib]: Consider replacing RelayNetworkStatusVote's getDirectorySignatures() with getDirectorySignature()

#18875: Consider replacing RelayNetworkStatusVote's getDirectorySignatures() with
getDirectorySignature()
---------------------------------+-------------------------
 Reporter:  karsten              |          Owner:  karsten
     Type:  enhancement          |         Status:  new
 Priority:  Medium               |      Milestone:
Component:  Metrics/metrics-lib  |        Version:
 Severity:  Normal               |     Resolution:
 Keywords:                       |  Actual Points:
Parent ID:                       |         Points:
 Reviewer:                       |        Sponsor:
---------------------------------+-------------------------

Comment (by tomlurge):

 RelayNetworkStatusVote is used for both Votes and Consensuses. For
 Consensuses returning a Map is the right thing to do. So don't deprecate
 getDirectorySignatures() altogether but maybe

  * add getDirectorySignature() to `RelayNetworkStatusVote`
  * or make sure that for a Vote the first or last (and preferably only)
 entry in the Map is the `DirSig`
  * or change `RelayNetworkStatusVote` into an interface
 `RelayNetworkStatus` with `RelayNetworkStatusVote` and
 `RelayNetworkStatusConsensus` as implementations (with the respective
 methods)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18875#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs