[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #18793 [Metrics/CollecTor]: add checkstyle task
#18793: add checkstyle task
-------------------------------+------------------------------
Reporter: iwakeh | Owner: iwakeh
Type: enhancement | Status: needs_review
Priority: Medium | Milestone:
Component: Metrics/CollecTor | Version:
Severity: Normal | Resolution:
Keywords: ctip | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
-------------------------------+------------------------------
Comment (by karsten):
Looks good! Merged and pushed to master. Thanks!
I noticed a possible problem with the `.gitignore` file though, and it's
not one that you're introducing but one that we should fix soon: we're not
prefixing any directories or files with a slash. So, if we ever add a
package `*.lib.*`, we'll ignore that in Git because it contains a `lib`
directory in its path. See also:
http://stackoverflow.com/questions/24139478/when-to-use-leading-slash-in-
gitignore
Please find [https://gitweb.torproject.org/karsten/metrics-
db.git/log/?h=task-18793 my branch task-18793] with a trivial patch on top
of yours (current master).
But, how do we continue with pleasing checkstyle? Do you want to write
patches, or should I start with the easy issues which produce 90% of
warnings, or how do we do this?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18793#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs