[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #18921 [Core Tor/Tor]: Fix IPv6 bridge client directory address selection
#18921: Fix IPv6 bridge client directory address selection
-------------------------------------------------+-------------------------
Reporter: teor | Owner:
Type: defect | Status:
Priority: Medium | merge_ready
Component: Core Tor/Tor | Milestone: Tor:
Severity: Normal | 0.2.8.x-final
Keywords: must-fix-before-028-rc | Version: Tor:
TorCoreTeam201604 | 0.2.8.1-alpha
Parent ID: #18483 | Resolution:
Reviewer: isis | Actual Points: 1 hour
| Points: small
| Sponsor:
-------------------------------------------------+-------------------------
Changes (by isis):
* status: needs_review => merge_ready
Comment:
Replying to [comment:5 teor]:
> Oh, hang on, we're getting the primary address because we want to put it
in an extend_info when creating a circuit to the third hop. So that's OK,
but I obviously need a better comment there.
>
> 7e5f0bb fixup! Choose the correct address for one-hop connection
> on my branch feature18483.
>
> And we don't have a node, so the node_get_prim_orport() function is out.
Oh, because an extend is happening. This makes more sense now.
Alright, everything looks good to me.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18921#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs