[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #18929 [Core Tor/Tor]: Fix selection of directories with non-preferred address families
#18929: Fix selection of directories with non-preferred address families
-------------------------------------------------+-------------------------
Reporter: teor | Owner:
Type: defect | Status:
Priority: Medium | needs_revision
Component: Core Tor/Tor | Milestone: Tor:
Severity: Normal | 0.2.8.x-final
Keywords: must-fix-before-028-rc, | Version: Tor:
CoreTorTeam201605 | 0.2.8.1-alpha
Parent ID: #18483 | Resolution:
Reviewer: isis | Actual Points: 2 hours
| Points: small
| Sponsor:
-------------------------------------------------+-------------------------
Changes (by isis):
* status: needs_review => needs_revision
Comment:
Replying to [comment:1 teor]:
> See commit
> e6f859c Make directory node selection for IPv4 bridge clients more
reliable
> in my branch feature18483 on âhttps://github.com/teor2345/tor.git
`router_has_non_preferred_address()` will return true if the
`routerstatus_t` has both an IPv4 and an IPv6 addressâ regardless of
whether IPv4 or IPv6 is preferred. This might still mess up the
`n_non_preferred` count?
If that's the right behaviour, then there's a unittest for you, for
`router_has_non_preferred_address()`, in my `bug18929`
[https://gitweb.torproject.org/user/isis/tor.git/log/?h=bug18929 branch]
(based on your `feature18483`). Otherwise we should make the unittest do
the intended thing and then revise.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18929#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs