Re: [tor-bugs] #18931 [Metrics/CollecTor]: coding style polishing

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#18931: coding style polishing
-------------------------------+-----------------------------
 Reporter:  iwakeh             |          Owner:  iwakeh
     Type:  task               |         Status:  merge_ready
 Priority:  Medium             |      Milestone:
Component:  Metrics/CollecTor  |        Version:
 Severity:  Normal             |     Resolution:
 Keywords:  ctip               |  Actual Points:
Parent ID:                     |         Points:
 Reviewer:                     |        Sponsor:
-------------------------------+-----------------------------
Changes (by iwakeh):

 * status:  needs_review => merge_ready


Comment:

 Wow, that was quick! And it looks fine!

 Maybe, we should remove the !CatchParameterName check?

 I'd like to have  a separate ticket for javadoc. Also for a discussion
 about how much javadoc is necessary.

 The things left (mostly renaming) can be done when working on other
 things,
 so I would suggest closing this after adding the javadoc ticket and
 removing
 the !CatchParameterName check, if you agree.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18931#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs