Re: [tor-bugs] #20680 [Applications/Tor Browser]: Rebase Tor Browser patches to 52 ESR

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#20680: Rebase Tor Browser patches to 52 ESR
-------------------------------------------------+-------------------------
 Reporter:  arthuredelstein                      |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:  new
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  ff52-esr, tbb-7.0-must,              |  Actual Points:
  TorBrowserTeam201703, tbb-7.0-must-nightly     |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor4
-------------------------------------------------+-------------------------

Comment (by gk):

 The final trove:

 `7a094d1375d3f127b23427362a1d22424ac3cfe3`: good
 `3882cea932e6b035120de45ca09d14cdd7314867`: good
 `70ed7f54da8a431970a8a35d6f6f2e3b7ff69a4d`:
 {{{
 +ac_add_options --enable-signmar
 +ac_add_options --enable-verify-mar
 }}}
 These are in the commit message for
 `16c4e654f2096b82a0e8922e29ee26a9f81b1ef0` and it seems to me enabling the
 signing things in all .mozconfig files does fit there better.

 `16c4e654f2096b82a0e8922e29ee26a9f81b1ef0`: good (see previous comment)
 `44316a8f135da5085111cdff409151282997d023`:

 1) In the second whitelist there is only "|welcomeback" but it seems
 "|tor" is missing (the esr45 patch has it)
 2)
 {{{
 +  // When electrolysis is enabled we will need to adopt an architecture
 that is
 +  // more similar to the one that is used for about:home (see
 AboutHomeListener
 +  // in this file and browser/modules/AboutHome.jsm).
 }}}
 Has this been done? Or is there at least a ticket filed somewhere?

 `dea0055d7dabfbe23fe8191b42dbf4ac0a9c02d0`: good
 `d6a9e29b04760f56bf7f4d82798d915da5a28c2c`: good
 `015699fe2b5fb82884e900901d7648727a720e06` (mozilla backport): good
 `697a2218e7c6511174e2946137d4f2d62aeca8c5` (mozilla backport): good (use
 fix for 1348841 instead or get it uplifted)
 `af782600b9ea29529a74d06e5c5cff6f4dfed0ad`: good
 `636eddeeb0ab2354689068257ff00b80199338b8`: good (changes due to #21309 I
 guess; do we have a follow-up ticket taking care of getting rid of the
 tor-browser-bundle changes needed in #18915?)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20680#comment:40>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs