[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #21920 [Applications/Tor Launcher]: Revert locale selection dialog changes in Tor Launcher
#21920: Revert locale selection dialog changes in Tor Launcher
-------------------------------------------------+-------------------------
Reporter: gk | Owner: brade
Type: enhancement | Status:
| needs_revision
Priority: Medium | Milestone:
Component: Applications/Tor Launcher | Version:
Severity: Normal | Resolution:
Keywords: tbb-7.0-must-alpha, | Actual Points:
TorBrowserTeam201704 |
Parent ID: | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Changes (by mcs):
* keywords: tbb-7.0-must-alpha, TorBrowserTeam201704R => tbb-7.0-must-
alpha, TorBrowserTeam201704
* status: needs_review => needs_revision
Comment:
The backout is somewhat messy. Are you sure we are not going to want this
feature again someday? It would be much easier to just change
`shouldPromptForLocale()` to always return false.
Looking at your changes, they look okay with the following small comments:
* The check against `mRestartWithQuit` can be removed from tl-process.js
(nothing sets that property).
* Kathy and I would prefer to keep the following prefs near the top of
defaults/preferences/prefs.js so as to avoid confusion (since they are not
related to the control port prefs): `extensions.torlauncher.start_tor` and
`extensions.torlauncher.prompt_at_startup`
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21920#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs