[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #20761 [Applications/Tor Launcher]: Tor Browser 6.5a4 is ignoring additional SocksPorts
#20761: Tor Browser 6.5a4 is ignoring additional SocksPorts
---------------------------------------+------------------------------
Reporter: gk | Owner: mcs
Type: defect | Status: needs_review
Priority: Medium | Milestone:
Component: Applications/Tor Launcher | Version:
Severity: Normal | Resolution:
Keywords: TorBrowserTeam201704R | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor: Sponsor4
---------------------------------------+------------------------------
Changes (by mcs):
* keywords: TorBrowserTeam201704 => TorBrowserTeam201704R
* status: needs_revision => needs_review
Comment:
Thanks for your review! Here is an updated patch:
https://gitweb.torproject.org/user/brade/tor-
launcher.git/commit/?h=bug20761-04&id=1781f041f00f8f18a05b49d848d50fad0a6be40d
We added comments to clarify the handling of comments within continued
lines. It is counterintuitive, but tor essentially ignores comments within
continued line sequences and does not interrupt the continued line. See
the definition of `ContinuedVal` within
https://gitweb.torproject.org/tor.git/tree/doc/torrc_format.txt. Also, we
did not attempt to preserve the comment in that case because it is
difficult to do so. Of course tor does not preserve comments when it
rewrites torrc in response to a SAVECONF command anyway, which will happen
if Tor Launcher's Network Settings dialog is ever used.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20761#comment:39>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs