Re: [tor-bugs] #21963 [Core Tor/Tor]: consdiff code accepts invalid patch

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#21963: consdiff code accepts invalid patch
--------------------------+------------------------------------
 Reporter:  Sebastian     |          Owner:
     Type:  defect        |         Status:  new
 Priority:  Medium        |      Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------
Description changed by Sebastian:

Old description:

> We shouldn't accept a patch that includes commands of the form
> '1,1a' because ranges for an add command don't make sense. I don't
> believe this is a breaking change because we never *generated* such
> diffs.

New description:

 We shouldn't accept a patch that includes commands of the form
 '1,2a' because ranges for an add command don't make sense. I don't believe
 this is a breaking change because we never *generated* such diffs.

--

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21963#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs