Re: [tor-bugs] #21978 [Core Tor/Tor]: hs: Decouple adding and validating a service

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#21978: hs: Decouple adding and validating a service
-----------------------------+------------------------------------
 Reporter:  dgoulet          |          Owner:  dgoulet
     Type:  enhancement      |         Status:  needs_review
 Priority:  Medium           |      Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor     |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:  tor-hs, prop224  |  Actual Points:
Parent ID:  #21888           |         Points:  0.2
 Reviewer:  asn              |        Sponsor:  SponsorR-must
-----------------------------+------------------------------------

Comment (by asn):

 OK this last branch made the changes slightly clearer.

 Changes LGTM.

 One thing I did not understand is why the validation function is not
 called by `rend_service_check_dir_and_add()`, and instead we have to call
 both functions in a row.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21978#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs