[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #22065 [Core Tor/Tor]: prop278: Parse the Accept-Encoding header and pass it to "get" handlers

#22065: prop278: Parse the Accept-Encoding header and pass it to "get" handlers
---------------------------------------+-----------------------------------
 Reporter:  nickm                      |          Owner:  nickm
     Type:  enhancement                |         Status:  merge_ready
 Priority:  Medium                     |      Milestone:  Tor:
                                       |  0.3.1.x-final
Component:  Core Tor/Tor               |        Version:
 Severity:  Normal                     |     Resolution:
 Keywords:  prop278 TorCoreTeam201704  |  Actual Points:  .1
Parent ID:  #21667                     |         Points:  .1
 Reviewer:                             |        Sponsor:  Sponsor4
---------------------------------------+-----------------------------------
Changes (by ahf):

 * status:  needs_review => merge_ready


Comment:

 Looks good. I have one comment:

 In 65ff0f8267b99a55a099eec2a71cb45557ae84eb the `HAVE_LZMA` and
 `HAVE_ZSTD` macros are used to build the `SUPPORTED_COMPRESSION_MASK`
 bitmask. Shouldn't we consider lifting that into the compress module
 instead with a public API there?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22065#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs