[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #20761 [Applications/Tor Launcher]: Tor Browser 6.5a4 is ignoring additional SocksPorts

#20761: Tor Browser 6.5a4 is ignoring additional SocksPorts
---------------------------------------+--------------------------------
 Reporter:  gk                         |          Owner:  mcs
     Type:  defect                     |         Status:  needs_revision
 Priority:  Medium                     |      Milestone:
Component:  Applications/Tor Launcher  |        Version:
 Severity:  Normal                     |     Resolution:
 Keywords:  TorBrowserTeam201704       |  Actual Points:
Parent ID:                             |         Points:
 Reviewer:                             |        Sponsor:  Sponsor4
---------------------------------------+--------------------------------

Comment (by gk):

 I think I've found another, more serious issue: the `\s+` in your matching
 regexes is wrong (e.g. in
 {{{
 +      let matchResult = aLine.match(/\s*\+*controlport\s+(.*)/i);
 }}}
 ).
 It is not guaranteed that you have at least one whitespace between key and
 value. Or are we optimizing for the `SAVECONF` case and there it is
 guaranteed?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20761#comment:41>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs