[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #23750 [Core Tor/Tor]: Isolate libevent usage to a few locations
#23750: Isolate libevent usage to a few locations
-------------------------------------------------+-------------------------
Reporter: nickm | Owner: nickm
Type: enhancement | Status:
| needs_review
Priority: Medium | Milestone: Tor:
| 0.3.4.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: refactoring, technical-debt, | Actual Points:
review-group-31, 034-triage-20180328, |
034-included-20180401 |
Parent ID: #25500 | Points:
Reviewer: dgoulet | Sponsor:
| Sponsor8
-------------------------------------------------+-------------------------
Changes (by nickm):
* status: needs_revision => needs_review
Comment:
Okay, I've made the requested changes!
First I had to rebase the branch, since there were several incompatible
changes to master since this branch began. Now it is in a new branch
called `isolate_libevent_2`.
I made the changes you requested, except for this:
> This function threadpool_register_reply_event() doesn't use the nice
mainloop_event_t API
The problem here is that mainloop_event_t is only for timed events or
events that we trigger via event_active(): we can't use it for events that
trigger via a socket.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23750#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs