Re: [tor-bugs] #25679 [Core Tor/Tor]: Default for TOR_RUST_DEPENDENCIES is wrong?

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#25679: Default for TOR_RUST_DEPENDENCIES is wrong?
---------------------------------------------+-----------------------------
 Reporter:  nickm                            |          Owner:  nickm
     Type:  defect                           |         Status:
                                             |  needs_revision
 Priority:  Medium                           |      Milestone:  Tor:
                                             |  0.3.3.x-final
Component:  Core Tor/Tor                     |        Version:
 Severity:  Normal                           |     Resolution:
 Keywords:  fast-fix, 033-included-20180403  |  Actual Points:
Parent ID:                                   |         Points:
 Reviewer:  catalyst                         |        Sponsor:
---------------------------------------------+-----------------------------
Changes (by catalyst):

 * status:  needs_review => needs_revision


Comment:

 It looks like that doesn't currently work because of the following lines
 which override it:

 {{{
     if test "x$NEED_MOD" = "x1"; then
       dnl When looking for dependencies from cargo, pick right directory
       TOR_RUST_DEPENDENCIES="../../src/ext/rust"
     fi
 }}}

 I'm not quite sure why it's trying to set it twice.  It would be good to
 understand why, and what `NEED_MOD` is meant to indicate.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25679#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs