[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #25355 [Core Tor/Tor]: Add option to set the facility of the syslog log backend dynamically

#25355: Add option to set the facility of the syslog log backend dynamically
-------------------------------------------------+-------------------------
 Reporter:  ahf                                  |          Owner:  (none)
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.4.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  review-group-34,                     |  Actual Points:
  034-triage-20180328                            |
Parent ID:                                       |         Points:
 Reviewer:  mikeperry                            |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by catalyst):

 * status:  merge_ready => needs_revision


Comment:

 Replying to [comment:8 nickm]:
 > What standard does this conform to?  How sure are we that every syslog.h
 includes CODE and facilitynames?
 I share this concern about portability.  The `SYSLOG_NAMES` macro, along
 with `facilitynames` and the `CODE` structure, seems to be a Linux (and
 maybe also macOS?) thing.  POSIX says nothing about it.

 We should check our assumptions at configure time and have a fallback in
 case these features aren't available.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25355#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs