[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #25679 [Core Tor/Tor]: Default for TOR_RUST_DEPENDENCIES is wrong?
#25679: Default for TOR_RUST_DEPENDENCIES is wrong?
---------------------------------------------+-----------------------------
Reporter: nickm | Owner: nickm
Type: defect | Status:
| needs_revision
Priority: Medium | Milestone: Tor:
| 0.3.3.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: fast-fix, 033-included-20180403 | Actual Points:
Parent ID: | Points:
Reviewer: catalyst | Sponsor:
---------------------------------------------+-----------------------------
Changes (by catalyst):
* status: needs_review => needs_revision
Comment:
Thanks, mostly looks good!
A few nits:
* `ERRORED` is probably not necessary because `AC_MSG_ERROR` already exits
the configure script with an error
* maybe `pwd` should be `pwd -P || pwd`, because bash will retain symbolic
link path components by default unless `set -o physical` is in effect.
(The `|| pwd` is in case we're running on a shell that's too old to
support `pwd -P`.)
Probably not for a bugfix (maybe a separate ticket):
* using `dnl` for comments prevents them from appearing in the generated
configure script; maybe these should be `#` comments instead. (I think
it's OK to match surrounding style for now.)
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25679#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs