[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #25700 [Metrics/Onionoo]: Fetch descriptors from both CollecTor instances

#25700: Fetch descriptors from both CollecTor instances
-----------------------------+--------------------------------
 Reporter:  karsten          |          Owner:  karsten
     Type:  enhancement      |         Status:  needs_revision
 Priority:  Medium           |      Milestone:  Onionoo 1.12.0
Component:  Metrics/Onionoo  |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:                   |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:  iwakeh           |        Sponsor:
-----------------------------+--------------------------------
Changes (by iwakeh):

 * status:  needs_review => needs_revision


Comment:

 Queues get added twice
 [https://gitweb.torproject.org/user/karsten/onionoo.git/tree/src/main/java/org/torproject/onionoo/updater/DescriptorSource.java?id=c7f62a33f665dc76528541124a3ceba583c50a4a#n57
 here].

 [https://gitweb.torproject.org/user/karsten/onionoo.git/tree/src/main/java/org/torproject/onionoo/updater/DescriptorSource.java?id=c7f62a33f665dc76528541124a3ceba583c50a4a#n50
 When constructing recentDir] the code is not necessarily platform
 independent, maybe use Paths.get.

 As Onionooo should be made easier to configure soon and we decided on
 having one config file (in #24041) maybe the construction of directories
 and supplying the hosts could be put in one place?  This would also avoid
 repeating the path concatenation.  Something like a list of host URL and
 in directory?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25700#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs