Re: [tor-bugs] #25700 [Metrics/Onionoo]: Fetch descriptors from both CollecTor instances

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#25700: Fetch descriptors from both CollecTor instances
-----------------------------+--------------------------------
 Reporter:  karsten          |          Owner:  karsten
     Type:  enhancement      |         Status:  needs_review
 Priority:  Medium           |      Milestone:  Onionoo 1.12.0
Component:  Metrics/Onionoo  |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:                   |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:  iwakeh           |        Sponsor:
-----------------------------+--------------------------------
Changes (by karsten):

 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:8 karsten]:
 > I just made the first two changes, but while looking into the third
 change I discovered a potential bug: it might be that we're reading and
 parsing the entire set of recent descriptors 7 times and throwing away all
 but one descriptor type in each execution. I need to look closer at that,
 but I have to leave for lunch now.

 False alarm. I overlooked a line that prevents just that. Phew.

 Alright, please find
 [https://gitweb.torproject.org/user/karsten/onionoo.git/commit/?h=task-25700&id=5c96f5c0ee2fb8d8fe85a4a16d9061608c421a0b
 commit 5c96f5c in my task-25700 branch]. I ''think'' that addresses all
 things you mentioned above. If not, please consider providing a fix, so
 that we can get this merged by end of today, if possible. I'm also
 currently running a local test.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25700#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs