[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #25712 [Metrics/Library]: Replace ServerDescriptor#getHiddenServiceDirVersions with ServerDescriptor#isHiddenServiceDir

#25712: Replace ServerDescriptor#getHiddenServiceDirVersions with
ServerDescriptor#isHiddenServiceDir
-----------------------------+-----------------------------
 Reporter:  karsten          |          Owner:  karsten
     Type:  enhancement      |         Status:  merge_ready
 Priority:  Low              |      Milestone:
Component:  Metrics/Library  |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:                   |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:                   |        Sponsor:
-----------------------------+-----------------------------
Changes (by iwakeh):

 * status:  needs_review => merge_ready


Comment:

 Always fine to have more eyes reviewing!

 Code seems fine; I'd only suggest using the 'default' method in
 ServerDescriptor, see [https://gitweb.torproject.org/user/iwakeh/metrics-
 lib.git/commit/?h=task-25712 this commit].

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25712#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs