[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #24256 [Metrics/Onionoo]: Add a new "outdated" field to distinguish between outdated and too new tor versions
#24256: Add a new "outdated" field to distinguish between outdated and too new tor
versions
-----------------------------+--------------------------------
Reporter: arma | Owner: karsten
Type: enhancement | Status: closed
Priority: High | Milestone: Onionoo 1.12.0
Component: Metrics/Onionoo | Version:
Severity: Normal | Resolution: fixed
Keywords: | Actual Points:
Parent ID: #25199 | Points:
Reviewer: iwakeh | Sponsor:
-----------------------------+--------------------------------
Comment (by iwakeh):
Replying to [comment:36 karsten]:
> Replying to [comment:35 iwakeh]:
> > Ready for merge, if you confirm that version status cannot be null in
the line added to DetailsDocumentWriter.
>
> I had that same thought after seeing both changes in that commit (which
I found and fixed separately). Actually the version status there ''can''
be null, but that's okay, because we're not invoking a method on it.
Alright, merging to master and re-closing. Thanks!
I'm not concerned about NPEs, but the string "null" appearing somewhere,
where it shouldn't be.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24256#comment:37>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs