[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #24734 [Core Tor/Tor]: Remove the return value of fascist_firewall_choose_address_node()
#24734: Remove the return value of fascist_firewall_choose_address_node()
-------------------------------------------------+-------------------------
Reporter: teor | Owner: neel
Type: defect | Status:
| needs_revision
Priority: Medium | Milestone: Tor:
| 0.3.4.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: ipv6, tor-relay, | Actual Points:
034-triage-20180328, 034-removed-20180328 |
Parent ID: #24403 | Points: 0.5
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):
* status: assigned => needs_revision
Comment:
Thanks for the patch.
These things need to be fixed:
Change comments like:
{{{
If neither address is chosen, return 0, else return 1.
}}}
So they say what the functions do now.
Make sure every function initialises the ap value before it returns. For
example, the first few lines in fascist_firewall_choose_address_rs(),
fascist_firewall_choose_address_node() and
fascist_firewall_choose_address_dir_server() leave this value
uninitialised. Please make this change in a separate commit or patch file.
Leaving return values uninitialised is a potential security issue, and we
should backport it to 0.2.9 and later.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24734#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs