[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #25386 [Core Tor/Tor]: fix rust tests
#25386: fix rust tests
-------------------------------------------------+-------------------------
Reporter: Hello71 | Owner: Hello71
Type: defect | Status:
| needs_revision
Priority: High | Milestone: Tor:
| 0.3.4.x-final
Component: Core Tor/Tor | Version: Tor:
| 0.3.3.1-alpha
Severity: Normal | Resolution:
Keywords: rust, tor-test, 033-backport, | Actual Points:
review-group-34, 034-triage-20180328, |
034-included-20180401 |
Parent ID: | Points: 3
Reviewer: isis | Sponsor:
| SponsorQ
-------------------------------------------------+-------------------------
Comment (by Hello71):
so it looks like building the shared library is actually the right way to
go. asan applies only to the shared library in this case, can probably use
`-Z sanitizer=address` on nightly for rust tests. few hitches:
1. libtool sucks. currently using meson. would rather we switch to that
entirely, but not opposed to someone else figuring out how to make
`libtor.so` (basically `tor` minus `tor_main.c`) using libtool instead
2. still figuring out how best to link it in; hopefully will not use
`RUSTFLAGS` so we don't have to recompile all dependencies on each test
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25386#comment:35>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs