[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #25425 [Core Tor/Tor]: Add unittests for bridges.c module

#25425: Add unittests for bridges.c module
-------------------------------------------------+-------------------------
 Reporter:  isis                                 |          Owner:  isis
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.4.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-unittests, tor-bridge, review-   |  Actual Points:
  group-35, 034-triage-20180328,                 |
  034-removed-20180328                           |
Parent ID:                                       |         Points:  2
 Reviewer:  ahf                                  |        Sponsor:
                                                 |  Sponsor8-can
-------------------------------------------------+-------------------------
Changes (by isis):

 * milestone:  Tor: unspecified => Tor: 0.3.4.x-final


Comment:

 Replying to [comment:10 ahf]:
 > I think this looks good!
 >
 > I only have some minor thing related to the `tt_finished()` macro:
 >
 > 1. The `;` in the macro definition is not needed, since `tt_finished();`
 will then get expanded to `tt_finished();;` (double ;).

 Ah right, good catch.

 > 2. Maybe it would make more sense to define `tt_finished()` as `#define
 tt_finished() TT_EXIT_TEST_FUNCTION`. I'm not sure here, but maybe Nick
 would have a good comment to add here since he knows the test subsystem
 very well.
 >
 > Once 1 is fixed I think this should be marked as merge ready.
 >

 Okay, I've fixed both of these in 0b8941b0b4, and I've re-squashed
 everything into a `bug25425_squashed2`
 [https://gitweb.torproject.org/user/isis/tor.git/log/?h=bug25425_squashed2
 branch] ([https://travis-ci.org/isislovecruft/tor/builds/364272812 Travis
 passes]) which should be mergeable.

 > (I laughed at the comment in c6610daa531690fee637eaac53fd3073d5b00e69)

 :) lol, I think I would die if I saw whitespace like that

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25425#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs