[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #25420 [Applications/Tor Browser]: Update gcc to 6.4.0 (Windows)
#25420: Update gcc to 6.4.0 (Windows)
-------------------------------------------------+-------------------------
Reporter: boklm | Owner: tbb-
| team
Type: task | Status:
| needs_revision
Priority: High | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: tbb-rbm, boklm201804, | Actual Points:
TorBrowserTeam201804 |
Parent ID: #24631 | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):
* keywords: tbb-rbm, boklm201804, TorBrowserTeam201804R => tbb-rbm,
boklm201804, TorBrowserTeam201804
* status: needs_review => needs_revision
Comment:
Okay, we are close! Testing the patches looks good. One thing I'd like to
see changed is the way you handle the Firefox patches: we should move them
into the `tor-browser` repo where possible, as it is otherwise hard for
folks building the browser part outside of the tor-browser-build
environment. Plus it makes it harder to keep track of the various patches
we have if they are in different places. Moving the patches to `tor-
browser` should be especially the case when we are unconditionally
applying patches as you did in your patch (I guess just enabling the three
patches for Windows would have been enough).
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25420#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs