[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #25511 [Core Tor/Tor]: Expose TZ info on control port for better debugging of time errors
#25511: Expose TZ info on control port for better debugging of time errors
-------------------------------------------------+-------------------------
Reporter: nickm | Owner: neel
Type: enhancement | Status:
| needs_revision
Priority: Medium | Milestone: Tor:
| 0.3.4.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: roadmap, controller, 034-roadmap- | Actual Points:
master, 034-triage-20180328, |
034-included-20180328, s8-errors |
Parent ID: | Points:
Reviewer: catalyst | Sponsor:
| Sponsor8
-------------------------------------------------+-------------------------
Changes (by catalyst):
* status: merge_ready => needs_revision
Comment:
Replying to [comment:30 neel]:
> I can understand the race condition.
>
> Should we do this? If so, how should we mock the `tor_gettimeofday()`?
In doc/HACKING/WritingTests.md are some instructions about how to make a
function mockable and how to later mock it in a test. Right now I think
`tor_gettimeofday()` isn't mockable, but that should be easily fixed.
Please let us know if you have additional questions or would like any help
with this.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25511#comment:33>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs