[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #25773 [Applications/Tor Browser]: Disable Speculative Connect and Download

#25773: Disable Speculative Connect and Download
--------------------------------------+--------------------------
 Reporter:  sysrqb                    |          Owner:  tbb-team
     Type:  defect                    |         Status:  new
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:                            |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+--------------------------

Comment (by sysrqb):

 Replying to [comment:8 sysrqb]:
 > Within scenario (1), Firefox cannot know what it should do without
 beginning the download. That's okay. With scenario (2), that is completely
 against what the user requested. This is almost certainly a Firefox bug,
 unfortunately it seems Firefox handles (1) and (2) using the same logic.

 Of course, Firefox wants to handle (2) in a smart way:

 {{{
     // an object to proxy the data through to
     // nsIExternalHelperAppService.doContent, which will wait for the
     // appropriate MIME-type headers and then prompt the user with a
     // file picker
 }}}
 https://gitweb.torproject.org/tor-
 browser.git/tree/browser/base/content/nsContextMenu.js?h=tor-
 browser-52.7.3esr-7.5-1-build1#n1265

 I wonder if we can simply use the timeout case instead, and skip the async
 fetch (?):
 {{{
       onStopRequest: function saveLinkAs_onStopRequest(aRequest, aContext,
                                                        aStatusCode) {
         if (aStatusCode == NS_ERROR_SAVE_LINK_AS_TIMEOUT) {
           // do it the old fashioned way, which will pick the best
 filename
           // it can without waiting.
           saveURL(linkURL, linkText, dialogTitle, bypassCache, false,
 docURI,
                   doc);
         }
 }}}
 https://gitweb.torproject.org/tor-
 browser.git/tree/browser/base/content/nsContextMenu.js?h=tor-
 browser-52.7.3esr-7.5-1-build1#n1319

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25773#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs