[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #25692 [Core Tor/Tor]: onion_extend_cpath: Non-fatal assertion info || client failed.
#25692: onion_extend_cpath: Non-fatal assertion info || client failed.
-------------------------------------------------+-------------------------
Reporter: nickm | Owner: (none)
Type: defect | Status: new
Priority: High | Milestone: Tor:
| 0.3.4.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: 034-must 033-backport regression | Actual Points:
chutney 034-included-20180403 033-maybe-must |
Parent ID: | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Comment (by nickm):
So, I see that extend_info_from_node() is returning NULL, but we aren't
seeing any warning about valid_addr being false ("Could not choose valid
address for...").
So that suggest to me that extend_info_from_node() is returning NULL
because of the earlier check:
{{{
if (is_bridge || !we_use_mds) {
/* We need an ri in this case. */
if (!node->ri)
return NULL;
} else {
/* Otherwise we need an md. */
if (node->rs == NULL || node->md == NULL)
return NULL;
}
}}}
We changed this check in d1874b433953f64b13a2feb0edc4bbff8940d503, to fix
#25213.
I am about 90% sure that only clients on chutney ever configure nodes as
bridges, so since "client" is false, "is_bridge" should be false too.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25692#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs