[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #25793 [Core Tor/Tor]: Refactor refactored token bucket API to be more generic

#25793: Refactor refactored token bucket API to be more generic
---------------------------------+------------------------------------
 Reporter:  nickm                |          Owner:  nickm
     Type:  defect               |         Status:  needs_revision
 Priority:  Medium               |      Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor         |        Version:
 Severity:  Normal               |     Resolution:
 Keywords:  034-roadmap-subtask  |  Actual Points:
Parent ID:  #25373               |         Points:
 Reviewer:  dgoulet              |        Sponsor:  Sponsor8-can
---------------------------------+------------------------------------
Changes (by dgoulet):

 * status:  needs_review => needs_revision


Comment:

 Review on the PR.

 I like it very much. I'm mostly concerned about the 32 bit "timestamp"
 which might not be ideal for Unix timestamp use case.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25793#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs