[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #25024 [Core Tor/Tor]: Add optional spell check to makefile to check for typos in tor source code.
#25024: Add optional spell check to makefile to check for typos in tor source code.
-------------------------------------------------+-------------------------
Reporter: fristonio | Owner: alison
Type: enhancement | Status:
| merge_ready
Priority: Low | Milestone: Tor:
| 0.3.4.x-final
Component: Core Tor/Tor | Version:
Severity: Minor | Resolution:
Keywords: tor-comment, review-group-34, | Actual Points:
034-triage-20180328 |
Parent ID: | Points: 0.5
Reviewer: asn | Sponsor:
-------------------------------------------------+-------------------------
Changes (by asn):
* status: needs_review => merge_ready
Comment:
Fixes look like they are addressing Nick's comments.
I feel like `+ $(top_srcdir)/src/[^e]*/*.[ch] \` is kind of a inelegant
way to exclude `src/ext/` but I don't know a better way to do it apart
from using `find` or something, and right now it should work OK. If this
feature ends up being useful, and we ever add another directory in `src/`
that starts with `e` we can think of a better approach there.
Setting this to `merge_ready` so that Nick can inspect it again.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25024#comment:31>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs