[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #25762 [Core Tor/Tor]: Make periodic events array with flags including when they are enabled/disabled

#25762: Make periodic events array with flags including when they are
enabled/disabled
-------------------------------------------------+-------------------------
 Reporter:  dgoulet                              |          Owner:  dgoulet
     Type:  defect                               |         Status:
                                                 |  assigned
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.4.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  034-roadmap-subtask, client,         |  Actual Points:
  s8-perf                                        |
Parent ID:  #25500                               |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor8
-------------------------------------------------+-------------------------

Comment (by nickm):

 I left some comments on the PR.

 My main suggestion here would be:
   * Always initialize every periodic event.  Instead of initializing only
 some...
   * Only call `periodic_event_launch()` on the events that should be
 running.
   * Add a `periodic_event_disable()` that delegates to
 `mainloop_event_cancel()`; call that on the events that should not be
 running.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25762#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs