Re: [tor-bugs] #25824 [Core Tor/Tor]: Integrate circuit max_cell_queue_size killer with DoS heartbeats

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#25824: Integrate circuit max_cell_queue_size killer with DoS heartbeats
--------------------------------+------------------------------------
 Reporter:  arma                |          Owner:  dgoulet
     Type:  enhancement         |         Status:  needs_revision
 Priority:  Medium              |      Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor        |        Version:
 Severity:  Normal              |     Resolution:
 Keywords:  tor-relay, tor-dos  |  Actual Points:
Parent ID:                      |         Points:
 Reviewer:                      |        Sponsor:
--------------------------------+------------------------------------
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 Quick review: this code looks okay but it makes unit tests fail:
 {{{
 status/log_heartbeat__not_in_consensus:
   FAIL src/test/test_status.c:443: unexpected call to logv()
   FAIL src/test/test_status.c:343: assert(CALLED(logv) OP_EQ 5): 6 vs 5
   [log_heartbeat__not_in_consensus FAILED]
 1/1076 TESTS FAILED. (31 skipped)
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25824#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs