[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #25834 [Applications/Tor Browser]: Use compiler dependent spec files for mingw-w64

#25834: Use compiler dependent spec files for mingw-w64
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-rbm, ff60-esr,                   |  Actual Points:
  TorBrowserTeam201804R                          |
Parent ID:  #24631                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by cypherpunks):

 Replying to [comment:5 gk]:
 > Replying to [comment:4 cypherpunks]:
 > > All this looks bad. Reply if you want to discuss.
 >
 > Just go ahead, we don't like the spec hack either.
 Agreed, if you continue the conversation. It seems easier to make the
 build work with mingw's `--with-default-msvcrt=msvcr100`, but there are
 also questions about the differences between a recommended way of building
 cross-compiler (with specs) and your setup. So, I'll summarize all the
 nits for the whole patched file as a code review (in comments).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25834#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs