[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #24734 [Core Tor/Tor]: Remove the return value of fascist_firewall_choose_address_node()
#24734: Remove the return value of fascist_firewall_choose_address_node()
-------------------------------------------------+-------------------------
Reporter: teor | Owner: neel
Type: defect | Status:
| merge_ready
Priority: Medium | Milestone: Tor:
| 0.3.4.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: ipv6, tor-relay, | Actual Points:
034-triage-20180328, 034-removed-20180328 |
Parent ID: #24403 | Points: 0.5
Reviewer: mikeperry | Sponsor:
-------------------------------------------------+-------------------------
Changes (by mikeperry):
* status: needs_review => merge_ready
Comment:
Ok I took Neel's patches and put them in a branch. I also noticed a couple
logic issues:
1. Since we're getting rid of the return value, and there was some code
relying on it that was changed to use tor_add_port_is_valid_ap(), we need
to zero the ap pointer before any early return from these functions for
those correctness checks to still be valid. I moved the zeroing code up in
a fixup commit for this. I double-checked that tor_addr_port_is_valid_ap()
rejects these zeroed addrs. It does, if they are also not AF_INET.
2. There were a couple of places that lacked a tor_assert(ap). So I added
them.
I added fixup commits for these.
Neel - be sure to consider calling, surrounding, and future code when you
make changes like this.
I think this is ready to go:
https://oniongit.eu/mikeperry/tor/commits/bug24734
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24734#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs