[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #25862 [Applications/Tor Browser]: Clean up wrapper script/CFLAGS and friends mix on Windows
#25862: Clean up wrapper script/CFLAGS and friends mix on Windows
-------------------------------------------------+-------------------------
Reporter: gk | Owner: tbb-
| team
Type: enhancement | Status:
| needs_review
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: tbb-rbm, boklm201804, | Actual Points:
TorBrowserTeam201804R |
Parent ID: | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Changes (by boklm):
* keywords: tbb-rbm => tbb-rbm, boklm201804, TorBrowserTeam201804R
* status: new => needs_review
Comment:
Replying to [comment:2 boklm]:
>
> I have been able to finish a build using this branch, however I did not
check yet if it is reproducible on a 2nd machine, and if the hardening of
the binaries is still good.
I have been able to reproduce this build on a 2nd machine. However,
running the testsuite on this build, the `win_DEP_ASLR` test is failing on
the firefox binaries. It seems to be caused by not having the linker flags
in the `g++` and `gcc` wrappers. A build with this fixup commit is fixing
the issue:
https://gitweb.torproject.org/user/boklm/tor-browser-
build.git/commit/?h=bug_25862&id=683c06c8347860cd8dcf8acc4bd7d36a2d46b9f8
A new version of the commit, including the fixup, is in branch
`bug_25862_v2`:
https://gitweb.torproject.org/user/boklm/tor-browser-
build.git/commit/?h=bug_25862_v2&id=34522dfd5345bc65794402b988dfd298620df0d1
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25862#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs