Re: [tor-bugs] #29950 [Applications/Tor Browser]: Error when using runc dev version

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#29950: Error when using runc dev version
--------------------------------------------+------------------------------
 Reporter:  boklm                           |          Owner:  tbb-team
     Type:  defect                          |         Status:  needs_review
 Priority:  Medium                          |      Milestone:
Component:  Applications/Tor Browser        |        Version:
 Severity:  Normal                          |     Resolution:
 Keywords:  TorBrowserTeam201903R, tbb-rbm  |  Actual Points:
Parent ID:                                  |         Points:
 Reviewer:                                  |        Sponsor:
--------------------------------------------+------------------------------
Changes (by boklm):

 * status:  needs_information => needs_review


Comment:

 Replying to [comment:2 gk]:
 > Any reason we use a capturing group in the regex if we aren't actually
 using the captured item? Seems to me a non-capturing group would do it as
 well here?

 Yes, a non-capturing group would work. I changed that in branch
 `bug_29950_v2`:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_29950_v2&id=32a4f009d706b9e651071b1b3d361891408eb3aa

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29950#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs