[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #29897 [Core Tor/Tor]: Refactor handle_get_next_bandwidth() to use connection_dir_buf_add()
#29897: Refactor handle_get_next_bandwidth() to use connection_dir_buf_add()
-------------------------------------------------+-------------------------
Reporter: teor | Owner: teor
Type: defect | Status: closed
Priority: Medium | Milestone: Tor:
| 0.4.0.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution: fixed
Keywords: consider-backport-after-authority- | Actual Points: 0.1
test, consider-backport-after-040-stable, |
tor-dirauth, metrics-needs, tor-bwauth, |
035-removed-20180711, 040-roadmap-proposed, |
040-backport |
Parent ID: #21377 | Points: 0.1
Reviewer: nickm | Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):
* status: merge_ready => closed
* keywords:
consider-backport-after-authority-test, consider-backport-
after-040-stable, tor-dirauth, metrics-needs, tor-bwauth,
035-removed-20180711, 040-roadmap-proposed, 035-backport-maybe-
in-21377, 040-backport
=>
consider-backport-after-authority-test, consider-backport-
after-040-stable, tor-dirauth, metrics-needs, tor-bwauth,
035-removed-20180711, 040-roadmap-proposed, 040-backport
* resolution: => fixed
* milestone: Tor: 0.3.5.x-final => Tor: 0.4.0.x-final
Comment:
Replying to [comment:7 nickm]:
> PR 867 looks okay -- I'm assuming that's what I'm supposed to review
here? Please let me know if I reviewed the wrong thing.
>
> Before we backport it, though, let's talk briefly about why we're doing
this. We usually don't backport refactoring stuff.
You're right, the code should be equivalent, so we don't need to backport
it.
I felt a little uncomfortable having different code in a bunch of
different releases. But I don't think we can avoid that problem, because
backporting refactoring is higher-risk than letting code diverge.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29897#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs