[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #28329 [Applications/Tor Browser]: Design TBA+Orbot configuration UI/UX

#28329: Design TBA+Orbot configuration UI/UX
-------------------------------------------------+-------------------------
 Reporter:  sysrqb                               |          Owner:  tbb-
                                                 |  team
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-mobile, ux-team, TBA-a3,         |  Actual Points:
  tbb-8.5-must-alpha, TorBrowserTeam201904       |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor8
-------------------------------------------------+-------------------------

Comment (by gk):

 Replying to [comment:86 gk]:
 > Replying to [comment:85 sysrqb]:
 > > I pushed branch `28329_28`. I deleted some of the animation-specific
 code we don't need currently. The main significant additional code is
 adjusting the onion graphic's width and height such that they aren't
 stretched. Android was forcing square dimensions with the SVG.

 [snip]

 > 2) After finishing the onboarding the `about:tor` page is loaded but
 there is no space between the text (Tor Browser Explore. Privately.) and
 the URL bar which looks a bit weird. I think the layout of that site
 should be as for the subsequent starts.

 Regarding that issue, I am not sure exactly why this is happening as the
 fixup commit looks good to me. However, double-checking with 8.5a8 shows
 it's a regression.

 Review so far:

 50729a60c1761e18a5586f0728cb68e9db0aff45 -- good
 ea2c582e0af381a2230d0288d457f92bfb401765 -- good
 db7b31d9a234c1f03a5c5508538f31d820aa525e -- good

 re: 1ee605c225fdf42631db9bd80790823eb700702d is that one we want to keep
 (just having it called `fixup!` makes me actually wonder. I suppose if
 it's not just a debugging help it was meant to be a fixup to the parent)?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28329#comment:87>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs