[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #29960 [Core Tor/Tor]: Actually check for errors in digest256_to_base64() and callers

#29960: Actually check for errors in digest256_to_base64() and callers
--------------------------------------+------------------------------------
 Reporter:  teor                      |          Owner:  teor
     Type:  enhancement               |         Status:  needs_revision
 Priority:  Medium                    |      Milestone:  Tor: 0.4.1.x-final
Component:  Core Tor/Tor              |        Version:  Tor: 0.2.2.6-alpha
 Severity:  Normal                    |     Resolution:
 Keywords:  technical-debt, fast-fix  |  Actual Points:  0.4
Parent ID:                            |         Points:  0.2
 Reviewer:  nickm                     |        Sponsor:  Sponsor31-can
--------------------------------------+------------------------------------
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 Looks good.  I've noted that a use of 'buf' in
 `ed25519_signature_from_base64` is no longer needed.  If you agree, please
 feel free to add an additional commit and put this in merge_ready.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29960#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs