[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #29702 [Core Tor/Tor]: Stop using configs from the local tor install when we launch tor for tests



#29702: Stop using configs from the local tor install when we launch tor for tests
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  rl1987
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.0.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.5.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  asn-merge, teor-merge, technical-    |  Actual Points:  0.1
  debt, tor-ci, tor-test, 035-backport,          |
  040-backport                                   |
Parent ID:                                       |         Points:  1
 Reviewer:  nickm                                |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  merge_ready => needs_revision


Comment:

 These changes are a good start, but they don't resolve the original issue:
 {{{
 $ make check
 $ grep usr src/test/test_rebind.sh.log
 2019-04-10 19:09:45.714 Tor logged: "Apr 10 19:09:45.709 [notice] Parsing
 GEOIP IPv4 file /usr/local/share/tor/geoip.", waiting for "Opened Socks
 listener"
 2019-04-10 19:09:46.128 Tor logged: "Apr 10 19:09:46.127 [notice] Parsing
 GEOIP IPv6 file /usr/local/share/tor/geoip6.", waiting for "Opened Socks
 listener"
 }}}

 I think we'll either need to change Tor's default share path at compile-
 time:
 {{{
 ./configure --datarootdir=src/config
 }}}

 Or explicitly supply `GeoIP` and `GeoIPv6` config lines in the defaults or
 user torrcs. (Or both, so that we catch future issues like this.)

 We might also want to set `configure --prefix` to an empty directory, to
 catch future issues like this.

 We also forgot to use an empty file for the defaults-torrc, so I added a
 commit to do that in all the scripts.

 Whatever we do, we should make sure we fix this issue in Travis and
 Appveyor.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29702#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs