[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #30051 [Core Tor/Tor]: Add practracker as a post-commit git hook for frequent coders
#30051: Add practracker as a post-commit git hook for frequent coders
-------------------------------------------------+-------------------------
Reporter: teor | Owner: rl1987
Type: enhancement | Status:
| needs_review
Priority: Medium | Milestone: Tor:
| 0.4.1.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: practracker tech-debt tor-ci git- | Actual Points:
scripts |
Parent ID: #29792 | Points: 1
Reviewer: asn | Sponsor:
-------------------------------------------------+-------------------------
Comment (by asn):
This seems to work for me.
An important thing here is that this script won't abort the commit when
practracker finds issues, which seems like a reasonable idea since maybe
you want to fix all the practracker issues on a subsequence commit.
However, this might be a problem for people using git wrappers (like me)
that ignore git-commit output, since they might not notice the failure.
Personally, I turned this into a pre-commit hook for this reason, but this
might not work for other people.
Tim, Nick, any opinions here?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30051#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs