[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #27609 [Applications/Tor Browser]: TBA: Evaluate Tor Onion Proxy Library
#27609: TBA: Evaluate Tor Onion Proxy Library
-------------------------------------------------+-------------------------
Reporter: sysrqb | Owner: tbb-
| team
Type: defect | Status:
| needs_revision
Priority: Very High | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: tbb-mobile, TBA-a3, tbb-8.5-must- | Actual Points:
alpha, TorBrowserTeam201904 |
Parent ID: | Points:
Reviewer: | Sponsor:
| Sponsor8
-------------------------------------------------+-------------------------
Comment (by gk):
Looking over the code of your `0411` branch and the essentially same
changes in `android-0318` I realized I forgot to mention two issues in
addition to those raised in comment:35:
1) please check the respective `gradle_dependencies_version` declarations
in the changed/added `config` files, they should either get incremented by
1 or start with 1 (the one for `tor_android_service` starts with 3 it
seems)
2) On a branch for review, could you please only put the commits on top of
`master` that are actually needed/intended to get reviewed? I am sure the
patch for #28764 is not, but am not so sure about the one for #28803.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27609#comment:56>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs