[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #30065 [Core Tor/Chutney]: Add shellcheck tests to chutney

#30065: Add shellcheck tests to chutney
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  teor
     Type:  enhancement                          |         Status:  closed
 Priority:  Medium                               |      Milestone:
Component:  Core Tor/Chutney                     |        Version:
 Severity:  Normal                               |     Resolution:  fixed
 Keywords:  chutney-ci, network-team-            |  Actual Points:  0.2
  roadmap-2019-Q1Q2                              |
Parent ID:  #29729                               |         Points:  0.2
 Reviewer:  nickm                                |        Sponsor:
                                                 |  Sponsor19
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:3 nickm]:
 > This LGTM, modulo rl1987's comment.

 I replied to rl1987's comment. I think it's good practice to explicitly
 list our dependencies, and insulate ourselves from future travis changes.

 Merged to master.
 Put the shellcheck tests before the unit tests when resolving a conflict.

 I merged #30059, #30063, #30064, and #30065, then pushed.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30065#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs